Optimize PersistentGenericSet snapshot #2394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maca88
commented
May 21, 2020
| } | ||
| if (_syncRoot == null) | ||
| { | ||
| Interlocked.CompareExchange<object>(ref _syncRoot, new object(), null); |
There was a problem hiding this comment.
Used the same logic as List<> has.
hazzik
reviewed
May 21, 2020
bahusoid
reviewed
May 22, 2020
|
Maybe we stick to the dictionary to avoid using conditional compilation? |
|
Also, hibernate just uses |
Co-authored-by: Frédéric Delaporte <12201973+fredericDelaporte@users.noreply.github.com>
Co-authored-by: Frédéric Delaporte <12201973+fredericDelaporte@users.noreply.github.com>
|
Hibernate is using HashMap, which supports null keys, so I think we should too.
To me using a dictionary is only a temporary solution until we upgrade to .NET Standard 2.1 or higher as |
This reverts commit 0ac69bd.
|
Is it possible to add unit tests for SetSnapshot (but no reflection please)? |
|
Tests added. |
hazzik
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative approach of #2393, which uses
HashSet<T>.TryGetValuefor .Net Core and a dictionary for .NET Framework