Add missing ISession.Get(entityName, id, lockMode) #2378
Merged
+300
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazzik
previously approved these changes
May 16, 2020
Co-authored-by: Frédéric Delaporte <12201973+fredericDelaporte@users.noreply.github.com>
fredericDelaporte
previously approved these changes
May 17, 2020
hazzik
reviewed
May 19, 2020
| return Get(clazz.FullName, id, lockMode); | ||
| } | ||
|
|
||
| /// <inheritdoc /> |
There was a problem hiding this comment.
<inheritdoc /> is not valid here because there is no parent.
Suggested change
| /// <inheritdoc /> | |
| /// <inheritdoc cref="SessionExtensions.Get" /> |
There was a problem hiding this comment.
I should probably go sleeping. It's my third attempt to put this comment. 🤦
There was a problem hiding this comment.
is not valid here because there is no parent.
Yeah we know it's been discussed here: #2378 (comment)
As this class is not intended to be used by end user I think it's OK to have it as is. It will become valid when we merge this method to interface. With you suggestion it's still invalid as multiple Get extensions are present. And we need to add to TODO to remove cref. So maybe leave it be...
hazzik
reviewed
May 19, 2020
bahusoid
commented
May 20, 2020
fredericDelaporte
approved these changes
May 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2313
IStatelessSession.Get(entityName, id, lockMode)is already present