Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid some cases of Type -> string -> Type conversion in Mapping By Code #2003

Merged
merged 11 commits into from
Feb 10, 2019
Merged

Avoid some cases of Type -> string -> Type conversion in Mapping By Code #2003

merged 11 commits into from
Feb 10, 2019

Conversation

bahusoid
Copy link
Member

@bahusoid bahusoid commented Feb 4, 2019 •
edited
Loading

Currently Mapping By Code can do excessive calls to TypeNameParser.ParseTypeName with pretty hardcore clean up/parse logic inside. But it's not needed for already known types.

@bahusoid bahusoid changed the title Avoid some cases of Type -> string -> Type conversion in Mapping By Code WIP Avoid some cases of Type -> string -> Type conversion in Mapping By Code Feb 4, 2019
@bahusoid bahusoid changed the title WIP Avoid some cases of Type -> string -> Type conversion in Mapping By Code Avoid some cases of Type -> string -> Type conversion in Mapping By Code Feb 5, 2019
@fredericDelaporte fredericDelaporte merged commit fff0d08 into nhibernate:master Feb 10, 2019
@fredericDelaporte fredericDelaporte added this to the 5.3 milestone Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazzik hazzik hazzik approved these changes

@fredericDelaporte fredericDelaporte fredericDelaporte approved these changes

Assignees
No one assigned
Labels
c: Core p: Minor r: Fixed t: Improvement
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@bahusoid @hazzik @fredericDelaporte