Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests for SQLite on .NET Core #1823

Merged
merged 2 commits into from
Oct 1, 2018
Merged

Conversation

hazzik
Copy link
Member

@hazzik hazzik commented Aug 14, 2018

No description provided.

@hazzik hazzik changed the title Run tests for SQLite for .NET Core Run tests for SQLite on .NET Core Aug 14, 2018
@hazzik hazzik added this to the 5.2 milestone Aug 14, 2018
Copy link
Member

@fredericDelaporte fredericDelaporte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the newer SQLite version needs a new keyword in the SQLite dialect: nothing.

<PackageReference Include="MySql.Data" Version="6.9.11" />
</ItemGroup>
<ItemGroup Condition="'$(TargetFramework)'=='netcoreapp2.0'">
<PackageReference Include="System.CodeDom" Version="4.4.0" />
<PackageReference Include="System.Data.SqlClient" Version="4.4.2" />
<PackageReference Include="System.Data.OracleClient" Version="1.0.8" />
<PackageReference Include="System.Data.Odbc" Version="4.5.0-preview1-25914-04" />
<PackageReference Include="System.Data.Odbc" Version="4.5.0" />

This comment was marked as resolved.

@hazzik
Copy link
Member Author

hazzik commented Aug 14, 2018

There is also a bug on Linux/MacOS X I’ve logged: https://system.data.sqlite.org/index.html/tktview?name=d292f2e23d

@hazzik

This comment has been minimized.

@fredericDelaporte
Copy link
Member

Visual Basic tests fail for SQLite. Maybe the project needs a direct reference.

@hazzik
Copy link
Member Author

hazzik commented Oct 1, 2018

Yes, I saw this.

@hazzik hazzik merged commit d506d3c into nhibernate:master Oct 1, 2018
@hazzik hazzik deleted the sqlite-core branch October 1, 2018 20:45
@hazzik hazzik added the r: Fixed label Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants