Support formula on one-to-many map-key #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a null reference exception in OneToManyPersister Spotted while testing nhibernate#1759
| @@ -76,7 +76,7 @@ protected override SqlCommandInfo GenerateDeleteString() | |||
| update.SetJoin(ownerPersister.TableName, KeyColumnNames, KeyType, JoinColumnNames, ownerPersister.GetPropertyColumnNames(CollectionType.LHSPropertyName)); | |||
| } | |||
|
|
|||
| if (HasIndex) | |||
| if (HasIndex && !indexContainsFormula) | |||
There was a problem hiding this comment.
This is from GenerateDeleteRowString own logic. It seems the GenerateDeleteString case was just forgotten.
By the way nullifying the index columns makes surely sense for an one-to-many list mapping, but for an one-to-many map mapping, this looks as a bad thing to me...
Anyway with this PR we will have a workaround if the nullifying of a map-key causes troubles: mapping it as a formula instead.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
hazzik
approved these changes
Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a null reference exception in OneToManyPersister
Spotted while testing #1759