Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise maximal decimal precision from 28 to 29 #1607

Merged

Conversation

fredericDelaporte
Copy link
Member

Details:

  • MySQL prior to version 5: it seems it was stored as string so with a huge precision, bumping 19 to 29.
  • SQLite: it does not handle precision/scale, it stores decimal in the same binary format than double. (Thus the HasBrokenDecimal set to true for SQLite, since it does not have a true decimal handling.) What should be changed then?
  • Oracle: double raised to 40 by the way, because it stores them as decimal but read them as .Net double, so it should not be limited to .Net decimal capabilities.
  • SybaseAsa9: default was 18,5 instead of 19,5.
  • SybaseAse15: default was 18,0 instead of 19,5. Set as 23,5 for avoiding a possible breaking change for those storing 10^18 numbers with the previous default.
  • Also standardizes Currency registration.

…ng factor.

 * Adjust default registrations of decimal and currency accross dialects for consistency.
 * Cease applying the decimal limit to Oracle double.
 * Fixes nhibernate#1606
@fredericDelaporte fredericDelaporte added this to the 5.1 milestone Mar 12, 2018
hazzik
hazzik previously approved these changes Mar 12, 2018
Copy link
Member

@hazzik hazzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on a condition that tests pass.

@hazzik
Copy link
Member

hazzik commented Mar 12, 2018

Need to update DriverTest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants