Optimize empty arrays usages #1490
Conversation
There was a problem hiding this comment.
60 empty arrays are still there, I am finding them with pattern: \[\s*\][^{=;,)]*\{\s*\}.
Overall I think this change is innocuous, so why not. But I wonder if it has a measurable impact.
By some ways it looks like the intern string "optimization": put in common identical non-mutable instances, sharing some memory usage (and maybe even some cpu), but at the cost of freezing their memory use (they will no more be garbage collected). So if empty arrays of too many different types are cached, it may overall cause the application to consume more memory permanently.
Now in the case of array types, they do not look to me as that much numerous, that is why I am in a "why not" stance for this change.
Upd: pattern was not correct, I have adjusted it, it catches one more case.
|
Yeah, I've forgotten about |
|
I have had a look with Frans's benchmark, no changes, same results with or without commits of this PR. |
No description provided.