Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong name value for L2 read-only cache warning on mutable #3210

Closed
spasecookee opened this issue Dec 15, 2022 · 1 comment
Closed

Wrong name value for L2 read-only cache warning on mutable #3210

spasecookee opened this issue Dec 15, 2022 · 1 comment

Comments

@spasecookee
Copy link

The way SessionFactoryImpl.GetCacheConcurrencyStrategy() is currently written, if a warning is logged, "read-only cache configured for mutable: {0}", the value provided to the log message is the readonly variable "name" which is always set to the value of the SessionFactoryName setting. This value is not very useful when trying to track down the source of the problem.

Instead something like the model.ClassName or model.Type.Name should be included in the logging message, depending on the caller. Alternatively, the log.warn should be moved outside GetCacheConcurrencyStrategy() and logged by the callers.

@fredericDelaporte fredericDelaporte changed the title SessionFactoryImpl.GetCacheConcurrencyStrategy() uses wrong name value when warning message is logged Wrong name value for L2 read-only cache warning on mutable Mar 25, 2023
@fredericDelaporte fredericDelaporte added this to the 5.3.16 milestone Mar 25, 2023
@bahusoid
Copy link
Member

Fixed by #3268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants