Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document IsDirty potential side effects #1449

Closed
fredericDelaporte opened this issue Nov 21, 2017 · 2 comments
Closed

Document IsDirty potential side effects #1449

fredericDelaporte opened this issue Nov 21, 2017 · 2 comments
Labels
c: Documentation p: Minor r: Fixed t: Improvement
Milestone
5.1

Comments

@fredericDelaporte
Copy link
Member

As described in #1413, ISession.IsDirty default implementation can have side effects with serious consequences. They should be documented.

  • It will trigger pending SaveOrUpdate cascades.
  • The triggered Save will generates the ids of the saved entities. Depending on the id generator, this may cause calls to the database, or even the direct insertion of the entities when using the identity generator.
@fredericDelaporte fredericDelaporte added this to the 5.1 milestone Nov 21, 2017
fredericDelaporte added a commit to fredericDelaporte/nhibernate-core that referenced this issue Nov 21, 2017
@fredericDelaporte
Document IsDirty side effects.
7f0968c 
 * Fixes nhibernate#1449.
@fredericDelaporte fredericDelaporte mentioned this issue Nov 21, 2017
Merged
@hazzik
Copy link
Member

hazzik commented Nov 21, 2017

@fredericDelaporte I think that we do not need to create an issue together with a PR, eg, if you know that you'll submit a PR shortly after the issue is created.

@fredericDelaporte
Copy link
Member Author

Yes, a bit "old Jira" reflex, I thought about it afterward.

fredericDelaporte added a commit that referenced this issue Nov 21, 2017
@fredericDelaporte
Document IsDirty side effects.
b6f16b6 
 * Fixes #1449.
joesun99 pushed a commit to joesun99/nhibernate-core that referenced this issue Nov 24, 2017
@fredericDelaporte @joesun99
Document IsDirty side effects.
c5e48ba 
 * Fixes nhibernate#1449.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: Documentation p: Minor r: Fixed t: Improvement
Projects
None yet
Milestone
5.1
Development

No branches or pull requests
2 participants
@hazzik @fredericDelaporte