Skip to content

Update the README pointing to wasm-wasi-component #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ac000
Copy link
Member

@ac000 ac000 commented Apr 17, 2024

Point people to the new wasm-wasi-component language module, but be upfront about its current limitations.

@ac000 ac000 force-pushed the updates branch 2 times, most recently from 3f8765a to e454edf Compare April 17, 2024 20:00
Point people to the new wasm-wasi-component language module, but be
upfront about its current limitations.

Signed-off-by: Andrew Clayton <a.clayton@nginx.com>
@ac000 ac000 marked this pull request as ready for review April 17, 2024 20:05
@avahahn
Copy link

avahahn commented Apr 18, 2024

I like the warnings about the performance limitations (until we fix them at least) but as a potential user I am not sure what I am being warned from in your statement about the rust ecosystem. I am also not sure what you are comparing it to.

Perhaps the warnings concerning performance limitations we can back up with data are worth keeping but I wonder if we can do without the concern about the rust ecosystem.

@ac000
Copy link
Member Author

ac000 commented Apr 18, 2024

I suppose the first warning is about the following

  1. Some people may rather not install all the rust stuff on their system (I'm not hugely keen myself!), much like they would rather not install all the java stuff, golang stuff etc and that applies to cargo as well, (my ~/.cargo directory is currently 1.4GiB in size). Thankfully Fedora has everything needed packaged up and I don't need to use the dangerous pipe random stuff from the Internet to the shell command...

  2. When building the wam-wasi-component module, it downloads and builds nearly 300 crates! and takes 5-7 minutes. I did a cargo clean in the wam-wasi-component directory the other day and it removed > 3.5GiB of stuff. In my view both of those are excessive...

  3. I can't even build the wasm-wasi-component model in my standard 512MiB VMs due to OOM, My main Fedora workstation is OK, but whenever I try to build it in say one of my Debian VMs, it fails the first time (because I forgot it needs more RAM) and need to restart it with more memory allocated and try again...

@lcrilly
Copy link

lcrilly commented Apr 18, 2024

These read to me more like prerequisites and system requirements than warnings. Install the toolchain, have enough disk space, have enough memory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants