Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swift 5.1 and Xcode 11 fixes #3

Merged
merged 4 commits into from
Nov 10, 2019
Merged

swift 5.1 and Xcode 11 fixes #3

merged 4 commits into from
Nov 10, 2019

Conversation

theromis
Copy link
Contributor

@theromis theromis commented Oct 6, 2019

No description provided.

Copy link

@thom-bahm thom-bahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea this is what I was boutta do, good job, this should be approved

@theromis
Copy link
Contributor Author

theromis commented Oct 7, 2019

still one warning: 'statusBarFrame' was deprecated in iOS 13.0: Use the statusBarManager property of the window scene instead.

for let statusBarHeight = UIApplication.shared.statusBarFrame.height
any idea how to fix it?

@theromis
Copy link
Contributor Author

theromis commented Oct 7, 2019

@QuantumThom extra question, is it possible to handle click outside of the menu to toggle it? Bonus question: will be perfect if I can add ability to slide menu back by holding it.

@theromis
Copy link
Contributor Author

theromis commented Oct 7, 2019

did a "dismissal trick" by putting

ZStack {
        GeometryReader { _ in
            EmptyView()
        }
        .background(Color.gray.opacity(0.3))
        .opacity(show ? 1.0 : 0.0)
        .animation(Animation.easeIn.delay(0.25))
        .onTapGesture {
            self.show = false
        }

under MenuView

@michaelmorehead
Copy link

for the statusBarHeight issue: 'statusBarFrame' was deprecated in iOS 13.0:
Use the statusBarManager property of the window scene instead.

// let statusBarHeight = UIApplication.shared.statusBarFrame.height

let window = UIApplication.shared.windows.filter {$0.isKeyWindow}.first
let statusBarHeight = window?.windowScene?.statusBarManager?.statusBarFrame.height ?? 0

@theromis
Copy link
Contributor Author

@michaelmorehead thank you, used your snippet as extra commit.
Hopefully they will merge finally my PR

@mythxn mythxn merged commit 2408457 into mythxn:master Nov 10, 2019
@mythxn
Copy link
Owner

mythxn commented Nov 10, 2019

@theromis Thanks for the update! Great work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants