Enable import of SSH key from files #355
Conversation
|
|
||
| public extension DefaultsKeys { | ||
| var pgpKeySource: DefaultsKey<PGPKeySource?> { .init("pgpKeySource") } | ||
| var pgpKeySource: DefaultsKey<KeySource?> { .init("pgpKeySource") } |
There was a problem hiding this comment.
I noticed one problem in the current TestFlight version with the changes in this file: The previous file is now itunes for both PGP and SSH keys. So, if a user had imported their keys via iTunes before the update, it will now be shown as imported from files. As far as I can see, this information is only relevant for the "✓" displayed in the import dialog to flag the used method. Shall we keep it since it is only UI related or shall we introduce another enum case for the import from files and keep file for iTunes, @mssun?
There was a problem hiding this comment.
Do you mean this UI issue is only valid for people using iTunes upgrading from older version? I think it's okay if there is no other side effect.
There was a problem hiding this comment.
Yes, url and armor have remained untouched. itunes is a new case and thus it is not known to UserDefaults. Only file changed to itunes, which causes the misinterpretation if iTunes was used for the key import. There are no errors, though, as no cases have been removed or renamed.
2 participants
KeyImporterprotocol mechanism like previously introduced for PGP key import.PGPKeySourceandGitSSHKeySource.