[CLOUDP-361632] Add functionality to upload release info to GitHub release assets #624
Conversation
viveksinghggits
requested review from
MaciejKaras,
lucian-tosa,
mircea-cosbuc,
nammn and
vinilage
and removed request for
a team and
lucian-tosa
|
Hi @MaciejKaras , @nammn @mircea-cosbuc @vinilage , thank you, sorry for the confusion. |
| run_on: | ||
| - ubuntu2404-small | ||
| allowed_requesters: ["patch", "github_tag"] | ||
| # depends_on: |
There was a problem hiding this comment.
why this is still commented out?
There was a problem hiding this comment.
I will remove this, I have commented this out because I don't want to mistakenly release the images while testing this.
There was a problem hiding this comment.
Sure, understand. Let's keep the thread unresolved until this is uncommented.
viveksinghggits
force-pushed
the
asset-image-info-json
branch
from
2f6ea42 to
f5fcd0d
Compare
| run_on: | ||
| - ubuntu2404-small | ||
| allowed_requesters: ["patch", "github_tag"] | ||
| # depends_on: |
There was a problem hiding this comment.
I will remove this, I have commented this out because I don't want to mistakenly release the images while testing this.
| raise e | ||
|
|
||
| def get_manfiest_list_digest(self, image) -> Optional[str]: | ||
| self.pull_image(image) |
There was a problem hiding this comment.
Pulling Ops Manager (which is huge) and other images just to get the digest seems like an overkill. Are we sure there is no other way?
There was a problem hiding this comment.
I looked into these ways of figuring out manifest list digest.
docker_cmd.buildx.imagetools.inspect(image_tag)
The python client that we are using doesn't return the manifest list digest, even though the respective CLI returns the required digest. So we can not use this way. I raised an issue upstream.
docker manifest inspect
Does not return the manifest list digest.
docker_cmd.image.inspect(image)
Works well and expects image to be pulled first.
docker inspect
Works well and expects image to be pulled locally.
There was a problem hiding this comment.
The overall process of making the release_info file is taking less than 10 (~6) seconds.
There was a problem hiding this comment.
The other option is to call HTTP API of container registry to figure the information out.
There was a problem hiding this comment.
Now that I was thinking about it again, the other option is to not use the python module and just run docker buildx imagetools inspect command directly. The small problem with this approach is, in the other functions we will be using the python package but in one method we will be running docker command directly.
There was a problem hiding this comment.
Why not use https://github.com/containers/skopeo to inspect remote images? It's the ideal tool for this case.
There was a problem hiding this comment.
I have used skopeo now to get the manifest list digest.
MCK 1.6.1 Release NotesBug Fixes
|
1. Move mapping field in json to root level 2. Change log lever for logs
1. Use `docker run skopeo inspect` to get digest of manifest list of a container image instead of docker inspect 2. Write unit test
viveksinghggits
force-pushed
the
asset-image-info-json
branch
from
d7108d6 to
f0a8b0f
Compare
Summary
As discussed in the base PR, customers have been asking us to provide some details that can be used to figure out the container images that they need to deploy a specific version of MCK and MongoDB instance.
This PR does that. It add the functionality to add a new file called
release_info_<release-version>.jsonto the GitHub release assets that would contain the details about MCK released images, OM, Agent, Search and the mapping between OM and agent's latest versions.This is how the file loos like
https://gist.github.com/viveksinghggits/560e6179a3c7d9b11b0df68f02b15ccc
Proof of Work
Run the patch manually
and make sure the new file is added to the release.
Screen.Recording.2025-12-02.at.23.00.35.mov
Screen.Recording.2025-12-02.at.23.08.27.mov
Checklist
skip-changeloglabel if not needed