-
Notifications
You must be signed in to change notification settings - Fork 23
CLOUDP-353164: Community/Enterprise Search TLS and cert manager changes #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
CLOUDP-353164: Community/Enterprise Search TLS and cert manager changes #572
Conversation
…grpc # Conflicts: # controllers/searchcontroller/mongodbsearch_reconcile_helper.go
…r-community-search-snippets
…r-community-search-snippets
fed0f08 to
922ba4c
Compare
MCK 1.6.0 Release NotesNew Features
Bug Fixes
Other Changes
|
6823713 to
52a2909
Compare
|
|
||
| mongotModification := func(config *mongot.Config) { | ||
| config.SyncSource.ReplicaSet.TLS = ptr.To(true) | ||
| config.SyncSource.CertificateAuthorityFile = ptr.To(tls.CAMountPath + "/" + tlsSourceConfig.CAFileName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not really related to snippets and it's a simple fix removing doubled // in mongot config.
52a2909 to
ca9d756
Compare
…-snippets-update' into anandsyncs/mck-search-enterprise-snippets-update # Conflicts: # docs/search/01-search-community-deploy/code_snippets/01_0040_validate_env.sh # docs/search/01-search-community-deploy/code_snippets/01_0308_issue_tls_certificates.sh # docs/search/02-search-enterprise-deploy/code_snippets/02_0040_validate_env.sh
| ${test_dir}/test.sh | ||
|
|
||
| echo "Sleeping for 120s to let replicaset nodes restarted and configured with the search configuration." | ||
| sleep 120 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not help a user running the snippets, should we add this as a real step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users won't be so quick when running the steps manually. Until we have the search status in MongoDB CR we won't have a good way to wait for the config to finish...
Co-authored-by: Anand <13899132+anandsyncs@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use the loop over the MDB_MEMBERS variable here like in Community?
Summary
Why: Making Search snippets with TLS-First
Our MongoDB Search snippets guide previously deployed without TLS. This PR overhauls them to be "TLS-first," adding and automating end-to-end encryption by default.
What's Changing:
Proof of Work
Tests pass
Checklist
skip-changeloglabel if not needed