-
Notifications
You must be signed in to change notification settings - Fork 23
CLOUDP-353163: remove search 8.0.10 support #559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…grpc # Conflicts: # controllers/searchcontroller/mongodbsearch_reconcile_helper.go
MCK 1.6.0 Release NotesNew Features
Bug Fixes
Other Changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes support for MongoDB 8.0.10 by raising the minimum required version for search features to 8.2.0, eliminating the need for legacy compatibility code that polyfilled the Search Coordinator role in older versions.
- Updated minimum version validation from 8.0.10 to 8.2.0 in both community and enterprise search source validation
- Removed Search Coordinator role polyfill logic that was previously needed for MongoDB versions below 8.2.0
- Updated all test cases to reflect the new 8.2.0 minimum version requirement
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
mongodb-community-operator/controllers/replica_set_controller.go |
Removed searchCoordinatorCustomRoleModification function and its call, along with the unused import |
controllers/searchcontroller/mongodbsearch_reconcile_helper_test.go |
Removed test cases for NeedsSearchCoordinatorRolePolyfill function |
controllers/searchcontroller/mongodbsearch_reconcile_helper.go |
Removed SearchCoordinatorRole and NeedsSearchCoordinatorRolePolyfill functions and their unused imports |
controllers/searchcontroller/enterprise_search_source_test.go |
Updated test cases from 8.0.10 minimum to 8.2.0 minimum |
controllers/searchcontroller/enterprise_search_source.go |
Updated version validation logic to require 8.2.0 instead of 8.0.10 |
controllers/searchcontroller/community_search_source_test.go |
Updated test cases from 8.0.10 minimum to 8.2.0 minimum |
controllers/searchcontroller/community_search_source.go |
Updated version validation logic to require 8.2.0 instead of 8.0.10 |
controllers/operator/mongodbsearch_controller_test.go |
Updated default test version from 8.0.10 to 8.2.0 |
controllers/operator/mongodbreplicaset_controller.go |
Removed Search Coordinator role polyfill logic |
changelog/20251015_other_remove_legacy_search_coordinator_polyfill.md |
Added changelog entry documenting the removal |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
changelog/20251015_other_remove_legacy_search_coordinator_polyfill.md
Outdated
Show resolved
Hide resolved
changelog/20251015_other_remove_legacy_search_coordinator_polyfill.md
Outdated
Show resolved
Hide resolved
fc149a0 to
cb83dbc
Compare
Summary
This pull request updates the minimum supported MongoDB version for search features to 8.2.0 and removes legacy compatibility logic for older versions. The main changes include raising the version requirements in validation logic and related tests, and cleaning up code that previously polyfilled the Search Coordinator role for older MongoDB versions.
Version requirement updates:
community_search_source.go,enterprise_search_source.go). [1] [2]community_search_source_test.go,enterprise_search_source_test.go). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]mongodbsearch_controller_test.go).Legacy code cleanup:
mongodbreplicaset_controller.go).changelog/20251015_other_remove_legacy_search_coordinator_polyfill.md).Minor dependency cleanup:
mongodbsearch_reconcile_helper.go). [1] [2]Proof of Work
Tests pass
Checklist
skip-changeloglabel if not needed