-
Notifications
You must be signed in to change notification settings - Fork 25
CLOUDP-295785 - simplify pipeline.sh script and use it for all images #543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ba6ef38 to
a15e493
Compare
MCK 1.6.0 Release NotesNew Features
Bug Fixes
|
| working_dir: src/github.com/mongodb/mongodb-kubernetes | ||
| binary: scripts/release/pipeline_version_upgrade_hook.sh | ||
| IMAGE_NAME: ${image_name} | ||
| BUILD_SCENARIO_OVERRIDE: ${build_scenario} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: did we add BUILD_SCENARIO_OVERRIDE so that we can build the images for different build scenarios manually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, we can still use BUILD_SCENARIO for that and pass it to evergreen cmd. The BUILD_SCENARIO_OVERRIDE is only used if we specify build_scenario in evergreen function call, so we can override BUILD_SCENARIO. Example:
# pct only triggers this variant once a new agent image is out
- name: release_agent
# this enables us to run this variant either manually (patch) which pct does or during an OM bump (github_pr)
allowed_requesters: [ "patch", "github_pr" ]
commands:
- func: clone
- func: setup_building_host
- func: quay_login
- func: setup_docker_sbom
- func: pipeline
vars:
image_name: agent
build_scenario: release
mircea-cosbuc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, used it for the CM agent release.
Summary
Combines all
pipeline.pyinvocations into singlepipeline.shscript which makes it easier to maintain and reduces amount of future bugs. The same principle was applied in.evergreen-functions.yml. Now we have only singlepipelineevergreen function. For evergreen extensions I've decided to stick with lower-case variable naming. This is aligning better with existing evg functions + less conflicts with context variables.This also fixes the bug, where the
BUILD_SCENARIO: releasefor OM and agent release tasks was not properly overriding the default one fromevg_private_context.Proof of Work
Checklist
skip-changeloglabel if not needed