-
Notifications
You must be signed in to change notification settings - Fork 23
[CLOUDP-352109] Run MCK E2E tests against OCI published helm chart #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
9bd1970 to
5f0938b
Compare
9d6699b to
4ad79ae
Compare
5f0938b to
1b61956
Compare
4ad79ae to
9394e7c
Compare
e885549 to
92d2fe6
Compare
464fc81 to
5d55e9f
Compare
b485e0c to
e81238f
Compare
MCK 1.6.0 Release NotesNew Features
Bug Fixes
Other Changes
|
1. Move file from scripts to scripts/relese 2. call python files from .sh files so that we can use build_scenario env var
| helm_args: Optional[Dict] = None, | ||
| helm_options: Optional[List[str]] = None, | ||
| helm_chart_path: Optional[str] = "helm_chart", | ||
| helm_chart_path: Optional[str] = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: how can we instruct this function to use local helm charts for local tests? Ideally we should be able to set this somewhere in the context files and override it by default locally, for example by specifying it in local-defaults-context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's the plan. I am working on the change that will make sure that we are able to run the tests locally. Will push the changes soon.
e2a0c99 to
5cb41a0
Compare
d32d374 to
f53071f
Compare
5bdab30 to
c482251
Compare
# Conflicts: # .evergreen.yml
c3fd0b0 to
ffceb0c
Compare
# Conflicts: # docker/mongodb-kubernetes-tests/kubetester/helm.py # docker/mongodb-kubernetes-tests/kubetester/operator.py # docker/mongodb-kubernetes-tests/tests/conftest.py
| logger = test_logger.get_test_logger(__name__) | ||
|
|
||
| # LOCAL_CRDs_DIR is the dir where local helm chart's CRDs are copied in tests image | ||
| LOCAL_CRDs_DIR = "helm_chart/crds" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Mixed casing
| import uuid | ||
| from typing import Dict, List, Optional, Tuple | ||
|
|
||
| from kubetester.consts import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Prefer explicit import for code navigation.
Summary
As part of our work to move towards OCI compatible container registries for our helm chart, we are also planning to run our E2E tests against the helm chart that we publish to OCI. This will make sure that we are testing in our E2E what we are providing to our customers.
As part of this effort we have already raised a PR that starts publishing our helm chart to the OCI container registry during dev/staging workflows.
This PR goes and changes our E2E tests to start consuming the helm chart from OCI registry instead of the local helm chart repo.
Additional unrelated change is to fix
kubectl-mongodblocation that is used for gke code snippets. The fix is to add missingworkdirpath suffix.Proof of Work
Successful CI on this PR.
I also ran the test
e2e_replica_set_migrationlocally and it was successful. The logs are here.publish_helm_chartexample output:Downloading the chart with
helm pull oci://268558157000.dkr.ecr.us-east-1.amazonaws.com/dev/mongodb/helm-charts/mongodb-kubernetes --untar --version 0.0.0+690bbc0f836fbf0007154375you can see that theChart.yamlversion was properly updated:Also run release test and e2e smoke tests are also passing (ignore
ibm_power, they are fixed in #573)Checklist
skip-changeloglabel if not needed