make aws_login checks for valid credentials #284
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds docker credentials verification in
make aws_loginto reliably refresh docker credentials only if needed.Previous method of skipping was checking if the ~/.docker/config.json was modified in the last six hours, but it wasn't reliable enough. If you performed docker login to any other registry or just modified the file, you won't get ECR credentials refreshed.
Proof of Work
breaking docker credentials (simulating expired):
from master - auth is skipped due to file modification time check only
from this PR:
running again skips properly:
Checklist