CLOUDP-65923: Replication state aware Readinessprobe #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
reviewed
Mar 22, 2021
Contributor
chatton
left a comment
chatton
left a comment
There was a problem hiding this comment.
Looks great! Can we also increase the readiness probe version in release.json (I guess to 1.0.2)
There is no automated process yet, but we want to push the new image here https://quay.io/repository/mongodb/mongodb-kubernetes-readinessprobe
The dockerfile is Dockerfile.readiness
rodrigovalin
force-pushed
the
CLOUDP-65923_replication_state_aware_readinessprobe
branch
from
b89c314 to
0d40d6e
Compare
rodrigovalin
force-pushed
the
CLOUDP-65923_replication_state_aware_readinessprobe
branch
from
ce6dbe5 to
3749c26
Compare
rodrigovalin
force-pushed
the
CLOUDP-65923_replication_state_aware_readinessprobe
branch
from
3749c26 to
d50e6bc
Compare
rodrigovalin
deleted the
CLOUDP-65923_replication_state_aware_readinessprobe
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The readiness probe understands the replication state of this MongoDB replication member. It will only set the Ready state when the Replication state is
PRIMARYorSECONDARY.All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).