CLOUDP-59612: Configure StatefulSet UpdatePolicy #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…59033_mongo_uri_in_status
LouisPlisso
reviewed
Mar 27, 2020
Comment on lines
+315
to
+320
| func getUpdateStrategyType(mdb mdbv1.MongoDB) appsv1.StatefulSetUpdateStrategyType { | ||
| if !mdb.ChangingVersion() { | ||
| return appsv1.RollingUpdateStatefulSetStrategyType | ||
| } | ||
| return appsv1.OnDeleteStatefulSetStrategyType | ||
| } |
chatton
changed the base branch from
CLOUDP-59033_mongo_uri_in_status
to
master
Contributor
rodrigovalin
left a comment
rodrigovalin
left a comment
There was a problem hiding this comment.
The status structure should be used to indicate status to a client (a person most of the time), but not for us to keep our temporary values between reconciliation.
What about "last-saved-configuration" to maintain what was "before" the current changes?
pkg/apis/mongodb/v1/mongodb_types.go
Outdated
| func (m *MongoDB) UpdateSuccess() { | ||
| m.Status.MongoURI = m.MongoURI() | ||
| m.Status.Phase = Running | ||
| m.Status.Version = m.Spec.Version |
Contributor
There was a problem hiding this comment.
we should not add the version to the status, given that it is already on the spec.
| if !statefulset.IsReady(set) { | ||
| log.Infof("Stateful Set has not yet reached the ready state, requeuing reconciliation") | ||
| return reconcile.Result{RequeueAfter: time.Second * 10}, nil | ||
| return fmt.Errorf("stateful Set has not yet reached the ready state, requeuing reconciliation"), time.Second * 10 |
Contributor
There was a problem hiding this comment.
this should log as info instead, this is not an "errorneous" situation.
rodrigovalin
approved these changes
Mar 31, 2020
Contributor
rodrigovalin
left a comment
rodrigovalin
left a comment
There was a problem hiding this comment.
LGTM!
This is looking really promising!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).Tested changing version manually
And when the pod is deleted manually, it restarts and reaches goal state, correctly joining the replica set