CLOUDP-302068: Refactoring: propagate env vars via parameters #1676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1kola
added
the
safe-to-test
m1kola
force-pushed
the
args_instead_of_env_vars
branch
from
3c64186 to
e89c0f7
Compare
m1kola
added
safe-to-test
m1kola
changed the title
m1kola
commented
Feb 21, 2025
Comment on lines
+63
to
+64
| construct.MongodbRepoUrlEnv, | ||
| construct.MongodbImageEnv, |
Collaborator
Author
There was a problem hiding this comment.
This is probably the most significant change in this PR: rest is moving things around and updating tests where applicable.
These env vars were not required before, but from the code it seems like they actually are required. So I'm adding them here. Would be good to get a sanity check here. Am I missing something? Is it actually possible and reasonable to run without them?
m1kola
force-pushed
the
args_instead_of_env_vars
branch
from
e89c0f7 to
3790e47
Compare
m1kola
added
safe-to-test
m1kola
commented
Mar 6, 2025
m1kola
force-pushed
the
args_instead_of_env_vars
branch
from
3790e47 to
51c2e36
Compare
m1kola
added
safe-to-test
m1kola
force-pushed
the
args_instead_of_env_vars
branch
from
51c2e36 to
ba14af9
Compare
m1kola
added
safe-to-test
m1kola
requested review from
Julien-Ben,
MaciejKaras,
fealebenpae,
lsierant,
lucian-tosa,
mircea-cosbuc and
nammn
as code owners
Julien-Ben
reviewed
Mar 10, 2025
nammn
approved these changes
Mar 10, 2025
Julien-Ben
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This will help with code reusability.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).