Add ability to watch secondary resources #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
approved these changes
Jul 21, 2020
Contributor
chatton
left a comment
chatton
left a comment
There was a problem hiding this comment.
Very clean implementation! I only had 2 small comments, nice work!
pkg/controller/watch/watch.go
Outdated
| } | ||
|
|
||
| // Add will add a new object to watch. | ||
| func (w ResourceWatcher) Add(watchedName, dependentName types.NamespacedName) { |
Contributor
There was a problem hiding this comment.
[nit] The name Add is a bit misleading, I think maybe something like EnsureAdded or EnsureWatched would be more accurate, what do you think?
Contributor
Author
There was a problem hiding this comment.
I agree that Add is a bit misleading but I'm not sure including Ensure adds much. How about Watch? Feels natural that you would Watch with a Watcher!
Contributor
There was a problem hiding this comment.
I think I'm okay with Watch!
pkg/controller/watch/watch.go
Outdated
Comment on lines
33
to
37
| for _, existingName := range existing { | ||
| if dependentName == existingName { | ||
| return | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
we cloud maybe add a contains.NamespacedName(nsNames, nsName) for this.
Contributor
Author
There was a problem hiding this comment.
True, added!
chatton
reviewed
Jul 22, 2020
Comment on lines
+26
to
+33
| func NamespacedName(nsNames []types.NamespacedName, nsName types.NamespacedName) bool { | ||
| for _, elem := range nsNames { | ||
| if elem == nsName { | ||
| return true | ||
| } | ||
| } | ||
| return false | ||
| } |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
This PR implements a custom
handler.EventHandlercalledResourceWatcher. This will allow us to watch for changes to specific secondary resources outside of the main MDB CRD. This PR is part of the work to implement support for TLS certificate rotations. The idea is to have oneResourceWatcheron theReconcilerfor each resource type we want to watch. If we for example have asecretWatcheron ourReconcilerwe can register it like:Resource to watch can then be added from the reconciliation loop using:
r.secretWatcher.Watch(objectToWatch, dependentObject).