Improve the toCollection and related API documentation
#1677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stIncMale
force-pushed
the
JAVA-5833
branch
3 times, most recently
from
ff4cfe4 to
d73f992
Compare
stIncMale
requested review from
a team,
rozza and
katcharov
and removed request for
a team
…shouldHaveTheSameMethods` JAVA-5833
|
We have the same test failures here, where they are obviously not caused by the change. Therefore, the failures here are also not caused by the changes. |
katcharov
approved these changes
Apr 11, 2025
|
Replaced Ross with @nhachicha, because Ross is away. |
katcharov
reviewed
Apr 11, 2025
Comment on lines
+218
to
+223
| /** | ||
| * Requests [AggregateFlow] to start streaming data according to the specified aggregation pipeline. | ||
| * - If the aggregation pipeline ends with an `$out` or `$merge` stage, then finds all documents in the affected | ||
| * namespace and emits them. You may want to use [toCollection] instead. | ||
| * - Otherwise, emits no values. | ||
| */ |
There was a problem hiding this comment.
Note to others that these docs and some others are new, and therefore non-trivial.
nhachicha
reviewed
Apr 14, 2025
driver-reactive-streams/src/main/com/mongodb/reactivestreams/client/AggregatePublisher.java
Outdated
Show resolved
Hide resolved
nhachicha
approved these changes
Apr 30, 2025
nhachicha
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rozza is the primary reviewer (chosen automatically), @katcharov is the secondary one (chosen manually based on the GitHub suggestion).
JAVA-5833