-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Optimize writing numeric values. #1635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
572efd9
c1d73ac
0e90c12
5a19a70
c693564
c7d6d4d
fce5610
01530aa
aac7ed8
53cbe5f
4ae828a
5983d1f
ee72dbc
28351b4
4b37c94
f9fcd60
183c081
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -117,6 +117,17 @@ public interface ByteBuf { | |
*/ | ||
ByteBuf putInt(int b); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Given that the interface includes the warning:
it is permissible to add new methods to this class. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add |
||
|
||
/** | ||
* Writes the given int value into this buffer at the current position, | ||
* using the current byte order, and increments the position by 4. | ||
* | ||
* @param b the int value to be written | ||
* @return this buffer | ||
* @throws java.nio.BufferOverflowException if there are fewer than 4 bytes remaining in this buffer | ||
* @throws java.nio.ReadOnlyBufferException if this buffer is read-only | ||
*/ | ||
ByteBuf putInt(int index, int b); | ||
|
||
/** | ||
* Writes the given double value into this buffer at the current position, | ||
* using the current byte order, and increments the position by 8. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Note] As @stIncMale suggested, lets put Evolving annotation here.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stIncMale I will add it in a follow-up PR as we don't have this annotation in
Bson
package.