[Server] Discovery fix McpTool meta parameters in place of icons #145
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpoiriert
requested review from
CodeWithKyrian,
Nyholm and
chr-hertel
as code owners
chr-hertel
approved these changes
Nov 11, 2025
Member
chr-hertel
left a comment
chr-hertel
left a comment
There was a problem hiding this comment.
Thanks @mpoiriert - the fix is already with #142 - but we can get this merge faster 👍
chr-hertel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The icons parameter in the constructor of Tools conflict with meta parameter
How Has This Been Tested?
I changed the file manually and reload the ChatGPT connector that use the meta information, and it worked.
Breaking Changes
Types of changes
Checklist
Additional context