Test and fix #52 #53
Open
Test and fix #52 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 13, 2025 21:43
e5l
requested changes
Mar 14, 2025
| @@ -39,7 +39,7 @@ public class SseClientTransport( | |||
| private var job: Job? = null | |||
|
|
|||
| private val baseUrl by lazy { | |||
| session.call.request.url.toString().removeSuffix("/") | |||
| session.call.request.url.toString().removeSuffix("/sse") | |||
There was a problem hiding this comment.
I would prefer to keep the prefix to have an explicit URL, but use the correct URL concatenation method to avoid duplicate // in path segments. There are several methods for pathSegment in Ktor you can use or build your own.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include a test to reproduce the issue #52 and solve it
Motivation and Context
SSE client can't connect to an SSE server because of wrong url handling
How Has This Been Tested?
An integration test has been written, in which an SSE client should successfully connect to an SSE server without mocking
Breaking Changes
No breaking changes
Types of changes
Checklist
Additional context