Update UIParticle.cs to change default scale to Vector3.one #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello - We've had some missteps with the default scaling of the particle system. Our VFX designer designs the particles but doesn't realize the default scale on the script is 10, and so has to go and do a lot of work editing the coefficients in the system (multiplying them all by 10) to get the VFX prefab to be correctly scaled. Propose: The default value for scaling is Vector3.one instead of 10f.
|
Sorry for the confusion regarding the scale. |
mob-sakai
added a commit
that referenced
this pull request
May 23, 2024
mob-sakai
added a commit
that referenced
this pull request
May 23, 2024
mob-sakai
added a commit
that referenced
this pull request
May 23, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 23, 2024
# [5.0.0-release-preview.1](v4.6.6...v5.0.0-release-preview.1) (2024-05-23) ### Features * add project settings for UIParticle ([b6e6185](b6e6185)) * change the default value of `UIParticle.scale` from `10` to `1` ([1b3c0f9](1b3c0f9)), closes [#310](#310) * UIParticle no longer inherits from MaskableGraphic ([b6d921b](b6d921b)) ### BREAKING CHANGES * Some members inherited from MaskableGraphic will no longer be available.
|
🎉 This issue has been resolved in version 5.0.0-release-preview.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
May 23, 2024
# [5.0.0-release-preview.1](v4.6.6...v5.0.0-release-preview.1) (2024-05-23) ### Features * add project settings for UIParticle ([b6e6185](b6e6185)) * change the default value of `UIParticle.scale` from `10` to `1` ([1b3c0f9](1b3c0f9)), closes [#310](#310) * UIParticle no longer inherits from MaskableGraphic ([b6d921b](b6d921b)) ### BREAKING CHANGES * Some members inherited from MaskableGraphic will no longer be available.
github-actions bot
pushed a commit
that referenced
this pull request
May 23, 2024
# [5.0.0-preview.1](v4.6.6...v5.0.0-preview.1) (2024-05-23) ### Features * add project settings for UIParticle ([b6e6185](b6e6185)) * change the default value of `UIParticle.scale` from `10` to `1` ([1b3c0f9](1b3c0f9)), closes [#310](#310) * UIParticle no longer inherits from MaskableGraphic ([b6d921b](b6d921b)) ### BREAKING CHANGES * Some members inherited from MaskableGraphic will no longer be available.
|
🎉 This issue has been resolved in version 5.0.0-preview.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
May 23, 2024
# [5.0.0-preview.1](v4.6.6...v5.0.0-preview.1) (2024-05-23) ### Features * add project settings for UIParticle ([b6e6185](b6e6185)) * change the default value of `UIParticle.scale` from `10` to `1` ([1b3c0f9](1b3c0f9)), closes [#310](#310) * UIParticle no longer inherits from MaskableGraphic ([b6d921b](b6d921b)) ### BREAKING CHANGES * Some members inherited from MaskableGraphic will no longer be available.
mob-sakai
added a commit
that referenced
this pull request
Jun 27, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jun 27, 2024
# [5.0.0-preview.1](v4.8.0...v5.0.0-preview.1) (2024-06-27) ### Features * add project settings for UIParticle ([945574d](945574d)) * change the default value of `UIParticle.scale` from `10` to `1` ([8f4fad9](8f4fad9)), closes [#310](#310) * UIParticle no longer inherits from MaskableGraphic ([4dd534c](4dd534c)) ### BREAKING CHANGES * Some members inherited from MaskableGraphic will no longer be available.
mob-sakai
added a commit
that referenced
this pull request
Jul 18, 2024
mob-sakai
added a commit
that referenced
this pull request
Sep 29, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 29, 2024
# [5.0.0-preview.1](v4.10.1...v5.0.0-preview.1) (2024-09-29) ### Features * change the default value of `UIParticle.scale` from `10` to `1` ([019240f](019240f)), closes [#310](#310) * UIParticle no longer inherits from MaskableGraphic ([b99a7c2](b99a7c2)) ### BREAKING CHANGES * Some members inherited from MaskableGraphic will no longer be available.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 29, 2024
# [5.0.0-preview.1](v4.10.1...v5.0.0-preview.1) (2024-09-29) ### Features * change the default value of `UIParticle.scale` from `10` to `1` ([019240f](019240f)), closes [#310](#310) * UIParticle no longer inherits from MaskableGraphic ([b99a7c2](b99a7c2)) ### BREAKING CHANGES * Some members inherited from MaskableGraphic will no longer be available.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 29, 2024
# [5.0.0-preview.1](v4.10.1...v5.0.0-preview.1) (2024-09-29) ### Features * change the default value of `UIParticle.scale` from `10` to `1` ([019240f](019240f)), closes [#310](#310) * UIParticle no longer inherits from MaskableGraphic ([b99a7c2](b99a7c2)) ### BREAKING CHANGES * Some members inherited from MaskableGraphic will no longer be available.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 29, 2024
# [5.0.0-preview.1](v4.10.1...v5.0.0-preview.1) (2024-09-29) ### Features * change the default value of `UIParticle.scale` from `10` to `1` ([019240f](019240f)), closes [#310](#310) * UIParticle no longer inherits from MaskableGraphic ([b99a7c2](b99a7c2)) ### BREAKING CHANGES * Some members inherited from MaskableGraphic will no longer be available.
mob-sakai
added a commit
that referenced
this pull request
Sep 29, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 29, 2024
# [5.0.0-release-preview.1](v4.10.1...v5.0.0-release-preview.1) (2024-09-29) ### Features * change the default value of `UIParticle.scale` from `10` to `1` ([8d49b2b](8d49b2b)), closes [#310](#310) * UIParticle no longer inherits from MaskableGraphic ([3cee38d](3cee38d)) ### BREAKING CHANGES * Some members inherited from MaskableGraphic will no longer be available.
mob-sakai
added a commit
that referenced
this pull request
Sep 29, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 29, 2024
# [5.0.0-preview.1](v4.10.1...v5.0.0-preview.1) (2024-09-29) ### Features * change the default value of `UIParticle.scale` from `10` to `1` ([6880a3f](6880a3f)), closes [#310](#310) * UIParticle no longer inherits from MaskableGraphic ([52eb28c](52eb28c)) ### BREAKING CHANGES * Some members inherited from MaskableGraphic will no longer be available.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 29, 2024
# [5.0.0-preview.1](v4.10.1...v5.0.0-preview.1) (2024-09-29) ### Features * change the default value of `UIParticle.scale` from `10` to `1` ([6880a3f](6880a3f)), closes [#310](#310) * UIParticle no longer inherits from MaskableGraphic ([52eb28c](52eb28c)) ### BREAKING CHANGES * Some members inherited from MaskableGraphic will no longer be available.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 29, 2024
# [5.0.0-preview.1](v4.10.1...v5.0.0-preview.1) (2024-09-29) ### Features * change the default value of `UIParticle.scale` from `10` to `1` ([6880a3f](6880a3f)), closes [#310](#310) * UIParticle no longer inherits from MaskableGraphic ([52eb28c](52eb28c)) ### BREAKING CHANGES * Some members inherited from MaskableGraphic will no longer be available.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 29, 2024
# [5.0.0-preview.1](v4.10.1...v5.0.0-preview.1) (2024-09-29) ### Features * change the default value of `UIParticle.scale` from `10` to `1` ([6880a3f](6880a3f)), closes [#310](#310) * UIParticle no longer inherits from MaskableGraphic ([52eb28c](52eb28c)) ### BREAKING CHANGES * Some members inherited from MaskableGraphic will no longer be available.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 29, 2024
# [5.0.0-preview.11](v5.0.0-preview.10...v5.0.0-preview.11) (2024-09-29) ### Features * change the default value of `UIParticle.scale` from `10` to `1` ([6880a3f](6880a3f)), closes [#310](#310) * UIParticle no longer inherits from MaskableGraphic ([52eb28c](52eb28c)) ### BREAKING CHANGES * Some members inherited from MaskableGraphic will no longer be available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've had some missteps with the default scaling of the particle system. Our VFX designer designs the particles but doesn't realize the default scale on the script is 10, and so has to go and do a lot of work editing the coefficients in the system (multiplying them all by 10) to get the VFX prefab to be correctly scaled.
Propose: The default value for scaling is Vector3.one instead of 10f.
name: Pull Request
about: Create a pull request
title: ''
assignees: mob-sakai
NOTE: Create a pull request to merge into
developbranch