Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add spatial_colors to plot_evoked_white #12725

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Conversation

larsoner
Copy link
Member

Closes #7992

Locally the test code when run with the following looks good:

MNE_MPL_TESTING_BACKEND=QtAgg pytest mne/viz/tests/test_evoked.py -k white --pdb

image

I touched the tutorials that seemed to use evoked.plot_white to make sure they look okay.

@larsoner larsoner added this to the 1.8 milestone Jul 17, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Member

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@drammock drammock merged commit 0c369e0 into mne-tools:main Jul 17, 2024
28 checks passed
@drammock drammock deleted the sc branch July 17, 2024 16:40
larsoner added a commit to larsoner/mne-python that referenced this pull request Jul 17, 2024
* upstream/main:
  ENH: Add spatial_colors to plot_evoked_white (mne-tools#12725)
  BUG: Fix bug with scale bar overplotting (mne-tools#12721)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evoked.plot_white() doesn't support spatial_colors
2 participants