ch01: fix nit in ESLint --fix result example #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error is mentioned in the screenshot above and is fixed in my local test run.
ljharb
reviewed
Feb 15, 2018
| @@ -311,7 +311,7 @@ When we run `lint-fix` we'll only get a pair of errors: `hello` is never used an | |||
| ---- | |||
| var goodbye = 'Goodbye!' | |||
|
|
|||
| function hello() { | |||
| function hello () { | |||
There was a problem hiding this comment.
Is this intentional? It’s very strange to have a space between the function name and the argument list.
There was a problem hiding this comment.
See https://github.com/mjavascript/practical-modern-javascript/blob/master/ch01.asciidoc#fig0102
Missing space before function parentheses
Maybe Standard activates https://eslint.org/docs/rules/space-before-function-paren ?
There was a problem hiding this comment.
lol, if so, it’s just another item to add to the list of how nonstandard “standard” is ¯\_(ツ)_/¯
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error is mentioned in the screenshot above and is fixed in my local
--fixrun.