Refactor/python coverage format #22
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 25, 2020
hslusarek
force-pushed
the
refactor/python_coverage_format
branch
from
6d6f2c4 to
5f86aaf
Compare
mikeferguson
requested changes
May 25, 2020
| COMMAND python-coverage combine || echo "WARNING: No python coverage to combine!" | ||
| COMMAND python-coverage xml || echo "WARNING: No python xml to output" | ||
| COMMAND python-coverage report --include "*${PROJECT_SOURCE_DIR}*" --omit ${COVERAGE_EXCLUDES} | ||
| COMMAND python-coverage html --include "*${PROJECT_SOURCE_DIR}*" --omit ${COVERAGE_EXCLUDES} || echo "WARNING: No python html to output" |
There was a problem hiding this comment.
Please either a) make the HTML an option or b) generate both XML and HTML. I know of several projects that are using codecov.io to process the XML output, so we can't break that workflow.
I presume we should add the include/omit to the XML report generation as well though?
Merged
knorth55
added a commit
to knorth55/code_coverage
that referenced
this pull request
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the python coverage reporting: