Simplify + clarify usage #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- automatically include(CodeCoverage) - clarify that APPEND_COVERAGE_COMPILER_FLAGS() needs to be called before defining any target
mikeferguson
approved these changes
Nov 19, 2019
| set(COVERAGE_EXCLUDES "*/${PROJECT_NAME}/test*" "*/${PROJECT_NAME}/other_dir_i_dont_care_about*") | ||
| add_code_coverage( | ||
| NAME ${PROJECT_NAME}_coverage | ||
| NAME ${PROJECT_NAME}_coverage_report |
There was a problem hiding this comment.
Seems reasonable, after merge I'll update the docs below so the names match
|
@rhaschke Thanks! All good ideas. 0.3.0 release is going out to kinetic/melodic now |
martiniil
added a commit
to PilzDE/pilz_robots
that referenced
this pull request
Nov 22, 2019
* add missing dependencies of tests * remove superfluous dependencies of tests * adapt to changes from mikeferguson/code_coverage#15
martiniil
added a commit
to PilzDE/pilz_industrial_motion
that referenced
this pull request
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are planning to use this package for MoveIt's Travis checks (moveit/moveit_ci#91), I would like to incorporate some simplifications, fixes, and clarifications before:
include(CodeCoverage)shouldn't be required explicitly. Rather these definitions should be included viafind_package()already.ENABLE_COVERAGE_TESTINGin the package's cmake file doesn't make sense. It needs to be defined in the module included by downstream packages.APPEND_COVERAGE_COMPILER_FLAGS()add_code_coverage()@mikeferguson, would be great, if you could create a new release into Kinetic and Melodic if this has been merged.