"focus": true not focusing

[drgrib]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version:
  Version: 1.84.0 (Universal)
  Commit: d037ac0
  Date: 2023-11-01T11:30:19.406Z
  Electron: 25.9.2
  ElectronBuildId: 24603566
  Chromium: 114.0.5735.289
  Node.js: 18.15.0
  V8: 11.4.183.29-electron.0
  OS: Darwin arm64 23.1.0
• OS Version: macOS Sonoma 14.1

Steps to Reproduce:

1. Create a task in task.json with this format

		{
			"label": "go mod tidy",
			"type": "shell",
			"command": "go mod tidy",
			"group": "build",
			"presentation": {
				"reveal": "always",
				"panel": "new",
				"focus": true,
				"echo": true
			},
		},

2. Open an editor window if not already open
3. Run the task
4. Notice that the cursor stays in the editor so the terminal must be clicked on to press enter and dismiss the task

[duncan-tincello]

I have the same fault in the same version of VSCode.

[kisielk]

Same problem with:

Version: 1.84.1
Commit: 2b35e1e6d88f1ce073683991d1eff5284a32690f
Date: 2023-11-06T12:35:31.181Z
Electron: 25.9.2
ElectronBuildId: 24603566
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Linux x64 5.15.0-88-generic snap

My task looks like this:

		{
			"label": "Flash firmware",
			"type": "shell",
			"command": "invoke flash",
			"presentation": {
				"echo": true,
				"reveal": "always",
				"focus": true,
				"panel": "shared",
				"showReuseMessage": false,
				"clear": false
			},
			"problemMatcher": []
		}

[cdschreiber]

Exactly the same here.

Version: 1.84.1
Commit: 2b35e1e6d88f1ce073683991d1eff5284a32690f
Date: 2023-11-06T12:35:31.181Z
Electron: 25.9.2
ElectronBuildId: 24603566
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Linux x64 5.15.0-88-generic

[cpsdev]

Same issue here.

Version: 1.84.2 (user setup)
Commit: 1a5daa3a0231a0fbba4f14db7ec463cf99d7768e
Date: 2023-11-09T10:51:52.184Z
Electron: 25.9.2
ElectronBuildId: 24603566
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Windows_NT x64 10.0.19045

[achamorro-dev]

Same here:

Version: 1.84.2
Commit: 1a5daa3a0231a0fbba4f14db7ec463cf99d7768e
Date: 2023-11-09T10:52:57.054Z (23 hrs ago)
Electron: 25.9.2
ElectronBuildId: 24603566
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Darwin arm64 23.0.0

In the 1.83 version it worked perfectly.

[gektus]

The same for me:

Version: 1.84.2 (Universal)
Commit: 1a5daa3a0231a0fbba4f14db7ec463cf99d7768e
Date: 2023-11-09T10:52:33.687Z
Electron: 25.9.2
ElectronBuildId: 24603566
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Darwin arm64 23.0.0