Update dependencies: March 2023 (TS 5.0) #1756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes in this PR will be published to the following url to try(check status of TypeSpec Pull Request Try It pipeline for publish status): Website: https://cadlwebsite.z1.web.core.windows.net/prs/1756/ |
timotheeguerin
force-pushed
the
upgrade/dep-march-2023
branch
from
718b87e to
a7b27b3
Compare
timotheeguerin
changed the title
timotheeguerin
commented
Apr 7, 2023
timotheeguerin
requested review from
bterlson,
daviwil,
nguerrera,
markcowl and
allenjzhang
as code owners
nguerrera
reviewed
Apr 7, 2023
nguerrera
reviewed
Apr 7, 2023
nguerrera
approved these changes
Apr 12, 2023
| @@ -36,7 +36,7 @@ export const NodeHost: CompilerHost = { | |||
| }, | |||
| getSourceFileKind: getSourceFileKindFromExt, | |||
| logSink: createConsoleSink(), | |||
| mkdirp: (path: string) => mkdirp(path), | |||
| mkdirp: (path: string) => mkdirp(path) as any, | |||
There was a problem hiding this comment.
the typing for that library is returning Promise<undefined | void> (void) causing issue. this triggered me also to create that remove mkdirp library issue as it is useless now
| @@ -387,7 +387,7 @@ export function createAssetEmitter<T, TOptions extends object>( | |||
| emitModelProperties(model) { | |||
| const res = typeEmitter.modelProperties(model); | |||
| if (res instanceof EmitterResult) { | |||
| return res; | |||
| return res as any; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generic dependency update. Notable:
-Typecript 5.0
Decide if we want this:
Resolved