Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow No Name #15

Merged
merged 3 commits into from Jan 11, 2019
Merged

Allow No Name #15

merged 3 commits into from Jan 11, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 29, 2018

On the route hello, a little bit of code was added to make the page not require a value for "Name" to be provided. Original functionally is not changed, however if name is not provided then a message on the screen says "You must provide a name" instead of getting the error "Not Found
The requested URL was not found on the server. If you entered the URL manually please check your spelling and try again."

adding in option for hello route so that "Name" is not required.
Added in logic so that "Name" is not required.  If name is not supplied then a message is displayed.
@msftclas
Copy link

msftclas commented Dec 29, 2018

CLA assistant check
All CLA requirements met.

@kraigb
Copy link
Contributor

kraigb commented Jan 11, 2019

Thanks for the improvement! I'll Update the related tutorial in the VS Code docs as well.

@kraigb kraigb merged commit 24f2fb9 into microsoft:master Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants