Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(56602): JSDoc render with @param Sub-object properties #56657

Merged
merged 3 commits into from
Dec 13, 2023
Merged

fix(56602): JSDoc render with @param Sub-object properties #56657

merged 3 commits into from
Dec 13, 2023

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #56602

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Dec 3, 2023
sandersn
sandersn requested changes Dec 12, 2023
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without opening this in an editor, I think you can make this less redundant by calling tryGetJSDocPropertyTags earlier. But I could be entirely wrong.

@sandersn sandersn requested a review from iisaduan December 12, 2023 17:16
@sandersn sandersn self-assigned this Dec 12, 2023
@a-tarasyuk a-tarasyuk requested a review from sandersn December 12, 2023 18:17
@sandersn sandersn merged commit d84be8e into microsoft:main Dec 13, 2023
c0sta pushed a commit to c0sta/TypeScript that referenced this pull request Dec 20, 2023
@a-tarasyuk @c0sta
fix(56602): JSDoc render with @param Sub-object properties (microsoft…
81b4d82 
…#56657)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

@iisaduan iisaduan Awaiting requested review from iisaduan

Assignees

@sandersn sandersn

Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSDoc render with @param Sub-object properties
3 participants
@a-tarasyuk @sandersn @typescript-bot