Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show error when trying to instantiate a union of abstract and concrete constructors #48114

Merged
merged 3 commits into from
Mar 5, 2022
Merged

Show error when trying to instantiate a union of abstract and concrete constructors #48114

merged 3 commits into from
Mar 5, 2022

Conversation

jihndai
Copy link
Contributor

@jihndai jihndai commented Mar 4, 2022

Constructor signatures' abstract check was not taking into account compositeSignatures when signature was of union type.

Fixes #48105

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Mar 4, 2022
@jihndai jihndai changed the title Fix instantiation of union of abstract and concrete constructors Show error when trying to instantiate a union of abstract and concrete constructors Mar 4, 2022
@RyanCavanaugh RyanCavanaugh requested a review from weswigham March 4, 2022 21:12
@weswigham weswigham merged commit 5f6ebf9 into microsoft:main Mar 5, 2022
@jihndai jihndai deleted the issue48105 branch March 5, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

Assignees
No one assigned
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instance can be created from union of abstract and concrete class without error
3 participants
@jihndai @weswigham @typescript-bot