Skip to content

Fix crash when this is typed as a generic T with no type constraints #47991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 5, 2022
Merged

Fix crash when this is typed as a generic T with no type constraints #47991

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a641b1e
fix this type validations for protected fields
jihndai Feb 28, 2022
cf64c78
update previous baselines
jihndai Feb 28, 2022
3fa1629
add new tests and baselines
jihndai Feb 28, 2022
4d415c9
ClassOrInterface can be returned as enclosingClass
jihndai Mar 1, 2022
ffe5d64
inline function code and remove unnecessary blank lines
jihndai Mar 3, 2022
bf6b745
refactor enclosingClass checks
jihndai Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update previous baselines
  • Loading branch information
@jihndai
jihndai committed Mar 3, 2022
commit cf64c78917e8ab1bf83ec624b6fef6dc6126f889
8 changes: 4 additions & 4 deletions tests/baselines/reference/publicGetterProtectedSetterFromThisParameter.errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
tests/cases/compiler/publicGetterProtectedSetterFromThisParameter.ts(33,7): error TS2446: Property 'q' is protected and only accessible through an instance of class 'A'. This is an instance of class 'B'.
tests/cases/compiler/publicGetterProtectedSetterFromThisParameter.ts(34,7): error TS2446: Property 'u' is protected and only accessible through an instance of class 'A'. This is an instance of class 'B'.
tests/cases/compiler/publicGetterProtectedSetterFromThisParameter.ts(33,7): error TS2445: Property 'q' is protected and only accessible within class 'B' and its subclasses.
tests/cases/compiler/publicGetterProtectedSetterFromThisParameter.ts(34,7): error TS2445: Property 'u' is protected and only accessible within class 'B' and its subclasses.


==== tests/cases/compiler/publicGetterProtectedSetterFromThisParameter.ts (2 errors) ====
Expand Down Expand Up @@ -37,9 +37,9 @@ tests/cases/compiler/publicGetterProtectedSetterFromThisParameter.ts(34,7): erro
// These should error
b.q = 0;
~
!!! error TS2446: Property 'q' is protected and only accessible through an instance of class 'A'. This is an instance of class 'B'.
!!! error TS2445: Property 'q' is protected and only accessible within class 'B' and its subclasses.
b.u = 0;
~
!!! error TS2446: Property 'u' is protected and only accessible through an instance of class 'A'. This is an instance of class 'B'.
!!! error TS2445: Property 'u' is protected and only accessible within class 'B' and its subclasses.
}