Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target: ES2021 #41239

Merged
merged 7 commits into from
Mar 10, 2021
Merged

Add target: ES2021 #41239

merged 7 commits into from
Mar 10, 2021

Conversation

saschanaz
Copy link
Contributor

Fixes #41238

We may never have year 2021 but TypeScript will.

@typescript-bot
Copy link
Collaborator

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 25, 2020
@jueinin
Copy link

jueinin commented Oct 26, 2020

you committed so much code...hard work!

@typescript-bot typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Oct 26, 2020
@saschanaz
Copy link
Contributor Author

General feedback: Could we stop putting esnext to file paths so that we can stop renaming it whenever new standard happens? It causes unnecessary and boring changes 😬

Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question about commandLineParser's remapping esnext.promise -> es2021.promise, plus the esnext transformer looks correct to me, but @rbuckton might have an opinion about it.

@typescript-bot
Copy link
Collaborator

The TypeScript team hasn't accepted the linked issue #41238. If you can get it accepted, this PR will have a better chance of being reviewed.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@minestarks
Copy link
Member

@uniqueiniquity the internal TypeScript / TypeScript-VS repos will need to be updated to match.

@Kingwl
Copy link
Contributor

Kingwl commented Mar 6, 2021

@saschanaz My bad. Got it!😂

@sandersn sandersn merged commit f4d0ea6 into microsoft:master Mar 10, 2021
@sandersn
Copy link
Member

@minestarks @uniqueiniquity This is merged now, so the internal repos need to update.

@saschanaz saschanaz deleted the es2021 branch March 10, 2021 21:32
@rbuckton
Copy link
Member

rbuckton commented Mar 10, 2021

I would note that ES2021 is still not official, per the ECMA. ES2021 is currently under the ECMA Royalty-Free Patent policy opt-out period which will last for two months, effective yesterday (March 9th, 2021). It won't officially become a standard until approximately May 9th, 2021. Nothing new can be added in that time, but its possible (though unlikely) that there could be a patent-related objection during the opt-out period that would result in a feature being removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add target: ES2021
7 participants