Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RWC test case sensitivity #24012

Merged
merged 2 commits into from
May 10, 2018

Conversation

weswigham
Copy link
Member

There's still another pair of RWC changes that were caused by the VFS change that we should probably just take baseline updates for - reordered input files (now matches what a real fs does) causing sourcemap and error baseline adjustments, and more reported input dupes from inconsistent casing (since there's no longer a pre-compile dedupe stage in the rwc runner); additionally JS baselines that previous had inconsistently slashed/cased paths logged at the top are now consistent.

Other RWC changes we have out (beyond the glimmer timeout) look to mostly be from renamed temp vars (from our recent generated name change) and some error span changes from property changes, though there's also a handful of new errors along the lines of Type 'T' is not assignable to type 'object', which are somewhat concerning.

@weswigham weswigham requested review from rbuckton and mhegazy May 10, 2018 00:09
@weswigham weswigham merged commit 58c7d7c into microsoft:master May 10, 2018
@weswigham weswigham deleted the fix-rwc-casesensitivity branch May 10, 2018 01:09
@microsoft microsoft locked and limited conversation to collaborators Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants