Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's still another pair of RWC changes that were caused by the VFS change that we should probably just take baseline updates for - reordered input files (now matches what a real fs does) causing sourcemap and error baseline adjustments, and more reported input dupes from inconsistent casing (since there's no longer a pre-compile dedupe stage in the rwc runner); additionally JS baselines that previous had inconsistently slashed/cased paths logged at the top are now consistent.
Other RWC changes we have out (beyond the glimmer timeout) look to mostly be from renamed temp vars (from our recent generated name change) and some error span changes from property changes, though there's also a handful of new errors along the lines of
Type 'T' is not assignable to type 'object'
, which are somewhat concerning.