Skip to content

Control flow analysis for implicit any variables #11263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Oct 6, 2016
Merged

Control flow analysis for implicit any variables #11263

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
38d16bb
Improve handling of ++ and -- in control flow analysis
ahejlsberg Sep 20, 2016
7df7bb2
Accept new baselines
ahejlsberg Sep 20, 2016
864ee1c
Use control flow analysis for let/var with no type annotation or init…
ahejlsberg Sep 21, 2016
dda8aac
Unify anyType and autoType when checking for identical declarations
ahejlsberg Sep 21, 2016
b14b24a
Update tests
ahejlsberg Sep 21, 2016
c37b790
Accept new baselines
ahejlsberg Sep 21, 2016
bd19f1d
Merge branch 'master' into controlFlowLetVar
ahejlsberg Sep 29, 2016
0621f7e
Control flow typing for variables with null or undefined initializer
ahejlsberg Sep 29, 2016
52d2aa5
Accept new baselines
ahejlsberg Sep 29, 2016
4479013
Report error on both declaration and reference when CFA can't determi…
ahejlsberg Sep 29, 2016
1c39cdc
Accept new baselines
ahejlsberg Sep 29, 2016
d8ec857
Add tests
ahejlsberg Sep 29, 2016
0739611
Accept new baselines
ahejlsberg Sep 29, 2016
6ae5337
Fix linting issue
ahejlsberg Sep 29, 2016
6c2344e
Add comments to tests
ahejlsberg Oct 3, 2016
dd63c46
Update tests and baselines
ahejlsberg Oct 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add tests
  • Loading branch information
@ahejlsberg
ahejlsberg committed Sep 29, 2016
commit d8ec85775ae80d0f497ab281ad99af8930410bc9
119 changes: 119 additions & 0 deletions tests/cases/compiler/controlFlowLetVar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,119 @@
// @strictNullChecks: true

declare let cond: boolean;

function f1() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if these functions had names that showed what they were testing.

let x;
if (cond) {
x = 1;
}
if (cond) {
x = "hello";
}
const y = x;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you have if (cond) .. else then y: string | number, right? Might be nice to have a case for that.

}

function f2() {
let x = undefined;
if (cond) {
x = 1;
}
if (cond) {
x = "hello";
}
const y = x;
}

function f3() {
let x = null;
if (cond) {
x = 1;
}
if (cond) {
x = "hello";
}
const y = x;
}

function f4() {
let x: any;
if (cond) {
x = 1;
}
if (cond) {
x = "hello";
}
const y = x;
}

function f5() {
var x;
if (cond) {
x = 1;
}
if (cond) {
x = "hello";
}
const y = x;
}

function f6() {
var x = undefined;
if (cond) {
x = 1;
}
if (cond) {
x = "hello";
}
const y = x;
}

function f7() {
var x = null;
if (cond) {
x = 1;
}
if (cond) {
x = "hello";
}
const y = x;
}

function f8() {
var x: any;
if (cond) {
x = 1;
}
if (cond) {
x = "hello";
}
const y = x;
}

function f9() {
let x;
if (cond) {
x = 1;
}
if (cond) {
x = "hello";
}
const y = x;
function f() {
const z = x;
}
}

function f10() {
let x;
if (cond) {
x = 1;
}
if (cond) {
x = "hello";
}
const y = x;
const f = () => {
const z = x;
};
}
120 changes: 120 additions & 0 deletions tests/cases/compiler/controlFlowNoImplicitAny.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,120 @@
// @strictNullChecks: true
// @noImplicitAny: true

declare let cond: boolean;

function f1() {
let x;
if (cond) {
x = 1;
}
if (cond) {
x = "hello";
}
const y = x;
}

function f2() {
let x = undefined;
if (cond) {
x = 1;
}
if (cond) {
x = "hello";
}
const y = x;
}

function f3() {
let x = null;
if (cond) {
x = 1;
}
if (cond) {
x = "hello";
}
const y = x;
}

function f4() {
let x: any;
if (cond) {
x = 1;
}
if (cond) {
x = "hello";
}
const y = x;
}

function f5() {
var x;
if (cond) {
x = 1;
}
if (cond) {
x = "hello";
}
const y = x;
}

function f6() {
var x = undefined;
if (cond) {
x = 1;
}
if (cond) {
x = "hello";
}
const y = x;
}

function f7() {
var x = null;
if (cond) {
x = 1;
}
if (cond) {
x = "hello";
}
const y = x;
}

function f8() {
var x: any;
if (cond) {
x = 1;
}
if (cond) {
x = "hello";
}
const y = x;
}

function f9() {
let x;
if (cond) {
x = 1;
}
if (cond) {
x = "hello";
}
const y = x;
function f() {
const z = x;
}
}

function f10() {
let x;
if (cond) {
x = 1;
}
if (cond) {
x = "hello";
}
const y = x;
const f = () => {
const z = x;
};
}