-
Notifications
You must be signed in to change notification settings - Fork 13.1k
Closed
Closed
Copy link
Labels
BugA bug in TypeScriptA bug in TypeScriptDomain: LS: Completion ListsThe issue relates to showing completion lists in an editorThe issue relates to showing completion lists in an editorEffort: CasualGood issue if you're already used to contributing to the codebase. Harder than "good first issue".Good issue if you're already used to contributing to the codebase. Harder than "good first issue".Fix AvailableA PR has been opened for this issueA PR has been opened for this issueGood First IssueWell scoped, documented and has the green lightWell scoped, documented and has the green lightHelp WantedYou can do thisYou can do this
Milestone
Description
Bug Report
🔎 Search Terms
- Method signature completions
- suggest / suggestions
- completions
🕗 Version & Regression Information
4.5.0-dev.20211029
💻 Code
For the code:
interface IFoo {
barOpt?(x: number): void;
}
class Foo implements IFoo {
|
}Complete barOpt inside Foo
🙁 Actual behavior
barOpt gets added with a ?
interface IFoo {
barOpt?(x: number): void;
}
class Foo implements IFoo {
barOpt?(x: number): void {
}
}🙂 Expected behavior
Since we have implemented the method, I'd expect us the remove the ?
andrewbranch
Metadata
Metadata
Assignees
Labels
BugA bug in TypeScriptA bug in TypeScriptDomain: LS: Completion ListsThe issue relates to showing completion lists in an editorThe issue relates to showing completion lists in an editorEffort: CasualGood issue if you're already used to contributing to the codebase. Harder than "good first issue".Good issue if you're already used to contributing to the codebase. Harder than "good first issue".Fix AvailableA PR has been opened for this issueA PR has been opened for this issueGood First IssueWell scoped, documented and has the green lightWell scoped, documented and has the green lightHelp WantedYou can do thisYou can do this