Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate 1 file to ko - Generic Classes #68

Conversation

yahma25
Copy link
Contributor

@yahma25 yahma25 commented Apr 3, 2021

en

번역 리뷰 요청합니다: @yeonjuan @bumkeyy
ref #6

감사합니다 😃

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2021

Thanks for the PR!

This section of the codebase is owned by @bumkeyy, @yeonjuan, and @guyeol - if they write a comment saying "LGTM" then it will be merged.

@yahma25
Copy link
Contributor Author

yahma25 commented Apr 3, 2021

대문자로 시작하는 영단어는 클래스를 의미한다고 판단하여 그대로 사용했습니다.
ex) Drawer, Sock, Dresser

대문자로 사용하더라도 s가 붙은 복수형은 사전적 의미대로 번역했습니다.
ex) Socks, TShirts, Coats

Copy link
Contributor

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다. 어색한 부분 제안 남겼습니다 :)

…sses.ts

Co-authored-by: YeonJuan <yeonjuan93@naver.com>
@yahma25
Copy link
Contributor Author

yahma25 commented Apr 24, 2021

@yeonjuan
제안 감사합니다~ 👍 반영하였습니다

@yeonjuan
Copy link
Contributor

LGTM

@github-actions github-actions bot merged commit 87f82fd into microsoft:main Apr 29, 2021
@github-actions
Copy link
Contributor

Merging because @yeonjuan is a code-owner of all the changes - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants