Improve typescript_tsdk lookup #748
Conversation
|
|
| log.warn("Path of tsserver.js: " + proc_file) | ||
| log.warn("Path of tsc.js: " + get_tsc_path()) |
There was a problem hiding this comment.
log.warn because now tsdk_location deduction is a bit more involved, and it's likely that more people will want to see what's going on. I've considered doing log.debug when typescript_tsdk setting isn't set, but the savings in noise are likely not worth the extra confusion of conditional logging.
There was a problem hiding this comment.
I agree with the log, I agree a bit less with skipping the conditional check, but it's not enough to block the PR 👍
There was a problem hiding this comment.
My idea was that people might think that they have a tsdk_location in the settings of their current project, while in fact they don't, and the missing log lines could slightly complicate the troubleshooting.
|
@orta @DanielRosenwasser Please, take a look, this fixes the most upvoted open issue. |
|
Conceptually this looks good, I need to get a working ST3 dev env again to verify this all works before I can merge - I might have time for that tomorrow 👍 |
|
@orta Friendly ping 😉 |
There was a problem hiding this comment.
I gave this a run with my dev copy of the compiler and it worked well, as well as testing without a typescript_tsdk and it resolved correctly to the built-in versions:
2020-06-08 16:41:17,996: 4575129024: WARNING: Path of tsserver.js: /Users/ortatherox/Library/Application Support/Sublime Text 3/Packages/TypeScript/tsserver/tsserver.js
2020-06-08 16:41:17,996: 4575129024: WARNING: Path of tsc.js: /Users/ortatherox/Library/Application Support/Sublime Text 3/Packages/TypeScript/tsserver/tsc.js
error: Package Control
| log.warn("Path of tsserver.js: " + proc_file) | ||
| log.warn("Path of tsc.js: " + get_tsc_path()) |
There was a problem hiding this comment.
I agree with the log, I agree a bit less with skipping the conditional check, but it's not enough to block the PR 👍
|
Thanks for the ping! |
|
Thank you for dedicating time to this! |
|
We reverted these changes, after looking at it we realized that the constant lookback for the tsdk could be a cross-user code eval security hole ( |
What ..?
So how come we'll use the react jsx now, provide help please!! |
Fix #538
This is flawed, of course, since the server used is never updated once initialized, so gotta restart ST when switching to/from a project with a custom
typescript_tsdkset, but I can't afford to spend time on a refactor to accommodate this, and this is still much better than the status quo.