Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to manage word completions inhibition #739

Merged
merged 5 commits into from
Dec 7, 2020

Conversation

msieurtoph
Copy link
Contributor

@msieurtoph msieurtoph commented Mar 5, 2020

#733 created a regression (see my comment : #733 (comment))

This PR adds a simple setting key to switch between old and new behavior.

Default behavior is the new one.
Turning setting auto_complete_inhibit_word_completions to True activates the old one.

I hope you will be OK with that.

@msftclas
Copy link

msftclas commented Mar 5, 2020

CLA assistant check
All CLA requirements met.

@msieurtoph
Copy link
Contributor Author

Looking back to my change, I think I found a cleaner way to switch between both behaviors, and properly return api completions only.
At least, I hope to ... ;)

The behavior fixed by original PR (#733) is preserved and should still work (as far as I tested it, it worked).

@orta
Copy link
Contributor

orta commented Dec 7, 2020

👍🏻 I'm for this, but it will need documenting in the README first

@msieurtoph
Copy link
Contributor Author

👍🏻 I'm for this, but it will need documenting in the README first

Done ;)

@orta
Copy link
Contributor

orta commented Dec 7, 2020

Cool, thanks!

@orta orta merged commit a607ddf into microsoft:master Dec 7, 2020
@msieurtoph msieurtoph deleted the fix-pr-733 branch December 7, 2020 15:21
@gcnew
Copy link

gcnew commented Oct 18, 2021

Hm.. word completions are still present for me unless I change the code to sublime.INHIBIT_WORD_COMPLETIONS | sublime.INHIBIT_EXPLICIT_COMPLETIONS as you initially did.

Update:

  • This PR untouched works in ST3, but there is a visual glitch as Sublime tries to render the default completion, it gets closed and then the TS one renders.
  • Doesn't work in ST4 unless the flags are set, but the visual glitch is always present :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants