-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting to manage word completions inhibition #739
Conversation
Looking back to my change, I think I found a cleaner way to switch between both behaviors, and properly return api completions only. The behavior fixed by original PR (#733) is preserved and should still work (as far as I tested it, it worked). |
👍🏻 I'm for this, but it will need documenting in the README first |
Done ;) |
Cool, thanks! |
Hm.. word completions are still present for me unless I change the code to Update:
|
#733 created a regression (see my comment : #733 (comment))
This PR adds a simple setting key to switch between old and new behavior.
Default behavior is the new one.
Turning setting
auto_complete_inhibit_word_completions
to True activates the old one.I hope you will be OK with that.