Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix common colorization issue in class/interface declaration. #238

Merged
merged 5 commits into from
Jul 27, 2015

Conversation

hoanhtien
Copy link
Contributor

Before:
image

After:
image

@msftclas
Copy link

Hi @hoanhtien, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

captures:
'1': { name: keyword.other.ts }
'2': { name: storage.type.ts }
'1': { name: storage.type.ts }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this cover the following case (from ts spec):

interface KeyValuePair<K, V> extends Array<K | V> { 0: K; 1: V; }

and

interface G<T, U extends Function> {  
    f<V extends U>(x: V): V;  
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a small problem with type argument i.e. <K | V> in the example above. This is fixed in the commit below.

@hoanhtien
Copy link
Contributor Author

The new commit fixes all scenarios in #226.

@zhengbli
Copy link
Contributor

👍

hoanhtien added a commit that referenced this pull request Jul 27, 2015
Fix common colorization issue in class/interface declaration.
@hoanhtien hoanhtien merged commit d88c895 into microsoft:master Jul 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants