-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix common colorization issue in class/interface declaration. #238
Conversation
Hi @hoanhtien, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
captures: | ||
'1': { name: keyword.other.ts } | ||
'2': { name: storage.type.ts } | ||
'1': { name: storage.type.ts } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this cover the following case (from ts spec):
interface KeyValuePair<K, V> extends Array<K | V> { 0: K; 1: V; }
and
interface G<T, U extends Function> {
f<V extends U>(x: V): V;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a small problem with type argument i.e. <K | V>
in the example above. This is fixed in the commit below.
…terface declaration.
The new commit fixes all scenarios in #226. |
👍 |
Fix common colorization issue in class/interface declaration.
Before:

After:
