Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Housekeeping upgrades #22

Merged
merged 2 commits into from
Jan 15, 2020
Merged

Conversation

matthewliuswims
Copy link
Contributor

👋 @weswigham thank you for your work :) this repo rocks! LMK if I need to make changes for this PR, and I'll be happy to make 'em

What

  • made config upgrades for the javascript and typescript repos with 2 corresponding commits. javascript here and typescript here
  • basically bumped versions of webpack, react and babel to modern versions with appropriate README changes

Why

  • webpack4, react16, and babel7 have been out for a while now and are the modern package versions. the typescript docs from what I've seen assumes those versions. so this PR is creating parity with the docs and with what many people probably have as dependency versions

How I tested

  • manually done and reproduced README steps. a quick sanity check one can do is npm install && npx webpack within the JS and typescript repo and open up index.html for each repo and verify everything was working

Miscellaneous

  • awesome-typescript-loader --> ts-loader....is because awesome-typescript-loader is deprecated while ts-loader is recommended throughout many of the docs

- webpack2 --> webpack4
- babel6 --> babel7
- react15 --> react16
- changed outpit file as now dist is implict in webpack
- webpack2 --> webpack4
- awesome-typescript-loader --> ts-loader
- update README
- some other small housekeeping things
@msftclas
Copy link

msftclas commented Jan 8, 2020

CLA assistant check
All CLA requirements met.

@matthewliuswims matthewliuswims changed the title House keeping upgrades Housekeeping upgrades Jan 8, 2020
@orta
Copy link
Contributor

orta commented Jan 15, 2020

Hi! Thanks for the detailed write-up, yeah, these changes look great to me - let's get them in.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants