selectionsort - decrease outer loop iteration and remove extra variable #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
do not iterate for last element as it is last one and no comarison left
Nirajkashyap
changed the title
mgechev
reviewed
Nov 7, 2019
.vscode/launch.json
Outdated
| @@ -0,0 +1,17 @@ | |||
| { | |||
Owner
There was a problem hiding this comment.
Let's remove this file. Feel free to add .vscode to .gitignore.
mgechev
reviewed
Nov 7, 2019
Owner
mgechev
left a comment
mgechev
left a comment
There was a problem hiding this comment.
LGTM. Left one comment regarding the config.
Contributor
Author
|
removed vscode config file and also update .gitignore for future reference. |
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.13.0 to 3.13.1. - [Release notes](https://github.com/nodeca/js-yaml/releases) - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.13.0...3.13.1) Signed-off-by: dependabot[bot] <support@github.com>
mgechev
approved these changes
Nov 8, 2019
Owner
|
Thanks! I'll update the list of contributors in the next a couple of weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.