Pep8 naming partial compliance #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore the `gui.py` file for now. There's lots of pep8-naming rules being thrown for this, and some of them could result in API changes. Too much to tackle at the moment.
mfisher87
commented
Jun 3, 2023
| ] | ||
|
|
||
| [tool.ruff.per-file-ignores] | ||
| "viscm/gui.py" = ["N8"] |
There was a problem hiding this comment.
This file is going to be a can of worms to apply pep8 naming conventions to. I think as this file is the largest by far in the repo, it will likely be slowly refactored into different modules over time as the need arises, and maybe as each small module gets extracted can have pep8 naming conventions applied at that time.
stefanv
approved these changes
Jun 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.