Fixup original unit test, set up tests to run in GitHub Actions #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfisher87
commented
Jun 2, 2023
mfisher87
commented
Jun 2, 2023
mfisher87
commented
Jun 2, 2023
mfisher87
commented
Jun 2, 2023
mfisher87
commented
Jun 2, 2023
test/test_editor_loads_native.py
Outdated
| colors = [ | ||
| # TODO: Should we divide by 255 here instead of 256? The tests pass with a | ||
| # lower value for `err` if we do. | ||
| [int(c[i : i + 2], 16) / 256 for i in range(0, len(c), 2)] |
There was a problem hiding this comment.
The maximum value of int(c[i : i + 2], 16) here (int('ff', 16)) is 255, so dividing by 256 is slightly compressing the resulting values towards 0 instead of producing a true 0-1 scale. Is this right?
There was a problem hiding this comment.
Sorry, want to be 100% sure I understand: Does dividing by 255 sound right to you, or 256?
|
Does this need to be rebased, now that I merged #65? |
|
Yes, will do so in the morning!
Matt
…On Thu, Jun 1, 2023, 10:15 PM Stefan van der Walt ***@***.***> wrote:
Does this need to be rebased, now that I merged #65
<#65>?
—
Reply to this email directly, view it on GitHub
<#66 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA3Q5SBNFBUNDOXC4K2YOBTXJFSE3ANCNFSM6AAAAAAYXVBXBQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
The unit test appears to have fallen out of sync with the code long ago (e.g. it seems to previously expect the values from `get_sRGB` to range from 0-255). I did my best to restore it, but at this point I'm not 100% sure why the colormaps only match approximately after applying these fixes.
|
@stefanv rebased and ready to go |
mfisher87
commented
Jun 2, 2023
mfisher87
commented
Jun 2, 2023
Merged
stefanv
approved these changes
Jun 3, 2023
test/test_editor_loads_native.py
Outdated
| colors = [ | ||
| # TODO: Should we divide by 255 here instead of 256? The tests pass with a | ||
| # lower value for `err` if we do. | ||
| [int(c[i : i + 2], 16) / 256 for i in range(0, len(c), 2)] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #65 first. Not sure what the best practice for opening chained/dependent PRs from a fork is. I'll just rebase once #65 is merged.