Modernize packaging config #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfisher87
commented
May 21, 2023
mfisher87
commented
May 21, 2023
stefanv
approved these changes
May 21, 2023
There was a problem hiding this comment.
Thanks, @mfisher87, this looks great! See whether you want to make any changes, otherwise I'm happy to merge.
| ``` | ||
| rm -rf dist | ||
| python -m build | ||
| pip install dist/*.whl # or `dist/*.tar.gz` |
There was a problem hiding this comment.
What is this or clause for?
There was a problem hiding this comment.
It's just a comment to point out the two different distributions that could be installed and tested locally. If the wheel works, the source dist should definitely work, so maybe not worth calling this out.
* Add anaconda.org URL to README * Fix minor error in README * Document passing a .py file as COLORMAP, clean up unnecessary comment * Relocate `__name__ == "__main__"` check to `cli` module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch up on the ecosystem changes from the last ~3 years :)
Support only non-EOL versions of Python (dropping 2.x support)